feat: Support all java.lang.Math in the query language #6110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
reviewed
Sep 27, 2024
| //////////////////////////// Constants //////////////////////////// | ||
|
|
||
| /** | ||
| * The double value that is closer than any other to e, the base of the natural logarithms. |
There was a problem hiding this comment.
Just a nit but I think this is a tad didactic. How about just "The mathematical constant e, the base of the natural logarithm".
There was a problem hiding this comment.
Docs are based off of the java.lang.Math wording.
| static public final double E = Math.E; | ||
|
|
||
| /** | ||
| * The double value that is closer than any other to pi, the ratio of the circumference of a circle to its diameter. |
There was a problem hiding this comment.
Also a nit, but likewise a tad didactic in my opinion. How about just "The mathematical constant pi".
There was a problem hiding this comment.
Docs are based off of the java.lang.Math wording.
chipkent
changed the title
kosak
reviewed
Oct 28, 2024
kosak
previously approved these changes
Oct 29, 2024
kosak
approved these changes
Oct 29, 2024
|
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#345 |
32 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly supported methods and constants:
Resolves #5995.