fix: Added support to read parquet files with empty row groups #6183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
parquet
malhotrashivam
changed the title
rcaudy
reviewed
Oct 8, 2024
| @@ -197,6 +197,10 @@ private RowSet computeIndex() { | |||
|
|
|||
| for (int rgi = 0; rgi < rowGroups.length; ++rgi) { | |||
| final long subRegionSize = rowGroups[rgi].getNum_rows(); | |||
| if (subRegionSize == 0) { | |||
There was a problem hiding this comment.
Does this address empty row groups in the middle of a file? It sort of looks like it does.
There was a problem hiding this comment.
Yes, it does, verified by generating such a file, added a test for it.
malhotrashivam
added a commit
to malhotrashivam/deephaven-core
that referenced
this pull request
Oct 9, 2024
|
Branch used for generating test data in this PR: https://github.com/malhotrashivam/deephaven-core/tree/sm-ref-branch |
rcaudy
approved these changes
Oct 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6179, #5530