Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Capture QueryCompiler for plotting PartitionedTable transform #6199

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: Capture QueryCompiler for plotting PartitionedTable transform #6199

merged 1 commit into from
Oct 16, 2024

Conversation

niloc132
Copy link
Member

Also removes other dead/deprecated code.

Fixes #6187

@niloc132 niloc132 added bug Something isn't working plotting NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Oct 14, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Oct 14, 2024
nbauernfeind
nbauernfeind approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@nbauernfeind nbauernfeind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we know that we do not need the QueryLibrary nor QueryScope, too.

rcaudy
rcaudy approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, if you've tested the reported case and it works now.

@niloc132 niloc132 merged commit 064aa6f into deephaven:main Oct 16, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees
No one assigned
Labels
bug Something isn't working NoDocumentationNeeded plotting ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.

oneClick with more than one filter column with a catPlot in does not work
3 participants
@niloc132 @nbauernfeind @rcaudy