feat: Add register to CleanupReferenceProcessor #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inspired by `java.lang.ref.Cleaner#register` which makes it very easy for callers to associate a cleanup action with an object without needing to deal with a Reference or ReferenceQueue.
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
reviewed
Oct 21, 2024
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
Util/src/main/java/io/deephaven/util/reference/CleanupReferenceProcessor.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public void cleanup() { |
There was a problem hiding this comment.
You could use interface defaulting to avoid this duplication....
There was a problem hiding this comment.
If there was more complex logic, I would consider it. In this case, I think per-impl is pretty straightforward.
|
running nightlies now... |
rcaudy
approved these changes
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by
java.lang.ref.Cleaner#registerwhich makes it very easy for callers to associate a cleanup action with an object without needing to deal with a Reference or ReferenceQueue.