Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Track links to omit in lychee #6291

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Conversation

jjbrosnan
Copy link
Contributor

@jjbrosnan jjbrosnan commented Oct 25, 2024

This adds a file that adds links to ignore when lychee gets run nightly. It can take regex.

Worth checking to make sure my regex isn't stupid, but I aim to omit:

  • Anything that contains localhost
  • Anything that contains docs.deephaven.io (enterprise docs)
  • The third link specifically

It may be worth passing enterprise docs auth parameters to check those as well.

This list was generated from https://github.com/deephaven/deephaven-core/actions/runs/11519370066/job/32068204051.

I will have a PR to fix other links in that run shortly.

@jjbrosnan jjbrosnan added size:1 Small task NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. github_actions Pull requests that update GitHub Actions code labels Oct 25, 2024
@jjbrosnan jjbrosnan self-assigned this Oct 25, 2024
@jjbrosnan jjbrosnan changed the title Track links to omit in lychee chore: Track links to omit in lychee Oct 25, 2024
devinrsmith
devinrsmith previously approved these changes Oct 25, 2024
@jjbrosnan jjbrosnan merged commit caccfdc into deephaven:main Oct 25, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update GitHub Actions code NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. size:1 Small task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants