fix: update S3ParquetTestBase testReadWriteUsingProfile #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an nightly error that deephaven#6305 introduced where `S3ParquetLocalStackTest.testReadWriteUsingProfile` was not erroring out with the use of an "invalid" region name. While we might want to have some sort of test like this, it should be standalone and not tied to the usage of profiles. As such, the corresponding code was removed. Ultimately, the behavior was traced down to a difference in behavior between localstack 3.6 and localstack 3.7; the region name logic must have changed in some way. We could do a deep dive into the commits to figure out why the behavior changed, or file an issue, if we care to pursue this further. https://github.com/localstack/localstack/releases/tag/v3.7.0
devinrsmith
added
test
NoDocumentationNeeded
NoReleaseNotesNeeded
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/S3ParquetTestBase.java
Show resolved
Hide resolved
malhotrashivam
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an nightly error that #6305 introduced where
S3ParquetLocalStackTest.testReadWriteUsingProfilewas not erroring out with the use of an invalid profile or credentials data (as far as the earlier images were concerned, localstack was failing based on the region and MinIO was failing based on the keys). While we might want to have some sort of test like this, it should be standalone and not tied to the usage of profiles. The invalid keys based test was separated out and only enabled for MinIO. An "invalid" region does not trigger this error for MinIO nor Localstack.Ultimately, the behavior was traced down to a difference in behavior between localstack 3.6 and localstack 3.7; the logic must have changed in some way. We could do a deep dive into the commits to figure out why the behavior changed, or file an issue, if we care to pursue this further.
https://github.com/localstack/localstack/releases/tag/v3.7.0