Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump the compiler, runtime, and test runtime version to Java 21 #6340

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Bump the compiler, runtime, and test runtime version to Java 21 #6340

wants to merge 2 commits into from

Conversation

devinrsmith
Copy link
Member

Fixes #3997

@devinrsmith devinrsmith added this to the Triage milestone Nov 6, 2024
@devinrsmith devinrsmith self-assigned this Nov 6, 2024
@devinrsmith
Copy link
Member Author

This is currently failing nightlies when run with Java 11 or 17, with the error

io.deephaven.lang.completion.ChunkerParserTest

java.lang.UnsupportedClassVersionError: io/deephaven/lang/completion/AllTokenIterableImpl has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0

@devinrsmith devinrsmith marked this pull request as ready for review November 7, 2024 18:17
@devinrsmith
Copy link
Member Author

GroovyCompile has been updated to fix the UnsupportedClassVersionError error.

@devinrsmith
Copy link
Member Author

Noted gradle/gradle#18824, gradle/gradle#22449 as links related to --add-exports and --release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloc132 niloc132 Awaiting requested review from niloc132

At least 1 approving review is required to merge this pull request.

Assignees

@devinrsmith devinrsmith

Labels
build NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.

Unable to compile with 17
1 participant
@devinrsmith