Skip to content

Commit

Permalink
fix missing refactors
Browse files Browse the repository at this point in the history
  • Loading branch information
wusteven815 committed Nov 12, 2024
1 parent 219f640 commit f5744dd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/date_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def date_field(
min_value: Date | UndefinedType = Undefined,
max_value: Date | UndefinedType = Undefined,
# TODO (issue # 698) we need to implement unavailable_values
# unavailable_values: Sequence[Date] | Undefined = UNDEFINED,
# unavailable_values: Sequence[Date] | Undefined = Undefined,
granularity: Granularity | UndefinedType = Undefined,
hour_cycle: HourCycle | UndefinedType = Undefined,
hide_time_zone: bool = False,
Expand Down
2 changes: 1 addition & 1 deletion plugins/ui/src/deephaven/ui/components/date_picker.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def date_picker(
min_value: Date | UndefinedType = Undefined,
max_value: Date | UndefinedType = Undefined,
# TODO (issue # 698) we need to implement unavailable_values
# unavailable_values: Sequence[Date] | Undefined = UNDEFINED,
# unavailable_values: Sequence[Date] | Undefined = Undefined,
granularity: Granularity | UndefinedType = Undefined,
page_behavior: PageBehavior | UndefinedType = Undefined,
hour_cycle: HourCycle | UndefinedType = Undefined,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def date_range_picker(
min_value: Date | UndefinedType = Undefined,
max_value: Date | UndefinedType = Undefined,
# TODO (issue # 698) we need to implement unavailable_values
# unavailable_values: Sequence[Date] | Undefined = UNDEFINED,
# unavailable_values: Sequence[Date] | Undefined = Undefined,
granularity: Granularity | UndefinedType = Undefined,
page_behavior: PageBehavior | UndefinedType = Undefined,
hour_cycle: HourCycle | UndefinedType = Undefined,
Expand Down
8 changes: 4 additions & 4 deletions plugins/ui/test/deephaven/ui/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_dict_to_camel_case(self):

def test_dict_to_react_props(self):
from deephaven.ui._internal.utils import dict_to_react_props
from deephaven.ui.types import UNDEFINED
from deephaven.ui.types import Undefined

self.assertDictEqual(
dict_to_react_props({"test_string": "foo", "test_string_2": "bar_biz"}),
Expand All @@ -103,7 +103,7 @@ def test_dict_to_react_props(self):
{"foo": None, "bar": "biz"},
)
self.assertDictEqual(
dict_to_react_props({"foo": UNDEFINED, "bar": "biz"}),
dict_to_react_props({"foo": Undefined, "bar": "biz"}),
{"bar": "biz"},
)
self.assertDictEqual(
Expand All @@ -122,14 +122,14 @@ def test_dict_to_react_props(self):

def test_remove_empty_keys(self):
from deephaven.ui._internal.utils import remove_empty_keys
from deephaven.ui.types import UNDEFINED
from deephaven.ui.types import Undefined

self.assertDictEqual(
remove_empty_keys({"foo": "bar", "biz": None, "baz": 0}),
{"foo": "bar", "biz": None, "baz": 0},
)
self.assertDictEqual(
remove_empty_keys({"foo": "bar", "biz": UNDEFINED, "baz": 0}),
remove_empty_keys({"foo": "bar", "biz": Undefined, "baz": 0}),
{"foo": "bar", "baz": 0},
)

Expand Down

0 comments on commit f5744dd

Please sign in to comment.