Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.flex is missing many props now #902

Closed
mofojed opened this issue Sep 23, 2024 · 2 comments · Fixed by #785
Closed

ui.flex is missing many props now #902

mofojed opened this issue Sep 23, 2024 · 2 comments · Fixed by #785
Assignees
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Sep 23, 2024

Description

As a result of ui.flex no longer just accepting **props after PR #810 , it's now missing some props: https://react-spectrum.adobe.com/react-spectrum/Flex.html#props
Add the missing props and document.

Steps to reproduce

  1. Add a flex with a height set:
from deephaven import ui

f = ui.flex("Hello", height="size-3000")

Expected results

  1. Flex element should appear

Actual results

  1. An error is thrown:
r-Scheduler-Serial-1 | .c.ConsoleServiceGrpcImpl | Error running script: java.lang.RuntimeException: Error in Python interpreter:
Type: <class 'TypeError'>
Value: flex() got an unexpected keyword argument 'height'
Line: 3

Versions
Engine Version: 0.36.1
Web UI Version: 0.90.0
Java Version: 11.0.24
Barrage Version: 0.6.0
Browser Name: Chrome 128
OS Name: Linux
@deephaven/js-plugin-plotly-express: 0.11.2
@deephaven/js-plugin-ui: 0.21.0

@mofojed mofojed added bug Something isn't working triage labels Sep 23, 2024
@mofojed mofojed removed the triage label Sep 23, 2024
@mofojed mofojed added this to the September 2024 milestone Sep 23, 2024
@mofojed mofojed assigned ethanalvizo and unassigned wusteven815 Sep 23, 2024
@mofojed
Copy link
Member Author

mofojed commented Sep 23, 2024

@ethanalvizo 's already fixing this as part of his flex docs PR: #785

@mofojed mofojed linked a pull request Sep 23, 2024 that will close this issue
@dsmmcken
Copy link
Contributor

Duplicate of #824

@dsmmcken dsmmcken marked this as a duplicate of #824 Sep 23, 2024
@dsmmcken dsmmcken closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants