Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: flex #785

Merged
merged 12 commits into from
Nov 5, 2024
Merged

docs: flex #785

merged 12 commits into from
Nov 5, 2024

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Aug 29, 2024 •
edited
Loading

Closes #688
Closes #824

@ethanalvizo ethanalvizo self-assigned this Aug 29, 2024
margaretkennedy
margaretkennedy reviewed Sep 3, 2024
View reviewed changes
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
dsmmcken
dsmmcken requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these examples cause bad overflow, which isn't your fault but they still look bad. I am down a rabbit hole on seeing if there's a global fix.

plugins/ui/docs/README.md Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
@mofojed mofojed mentioned this pull request Sep 23, 2024
Closed
@mofojed mofojed linked an issue Sep 23, 2024 that may be closed by this pull request
ui.flex is missing many props now #902
Closed
@mofojed
Copy link
Member

mofojed commented Sep 24, 2024

@ethanalvizo can you separate the flex.py changes into their own PR so they can be merged to fix #824? Docs could still use more work but want to merge the flex props changes

@ethanalvizo ethanalvizo mentioned this pull request Sep 27, 2024
Merged
@ethanalvizo
Copy link
Contributor Author

Should be merged after #912 since that contains the flex pydocs in this PR

mofojed pushed a commit that referenced this pull request Sep 27, 2024
@ethanalvizo
docs: flex pydocs (#912)
5fb0ed5 
Closes #824 

Separated from markdown docs in other flex
[PR](#785)
dsmmcken
dsmmcken requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase/merge main so I can review against new panel overflow behaviour

wusteven815 added a commit to wusteven815/deephaven-plugins that referenced this pull request Oct 1, 2024
@wusteven815
Squashed commit of the following:
28e370a 
commit 94206d8
Author: Steven Wu <wusteven815@gmail.com>
Date:   Tue Oct 1 11:29:19 2024 -0400

    fix: text_field events throw error (deephaven#913)

    - Fixes deephaven#893
    - Generalize the text area hook to be used for any text input, and make
    `text_field` use that

commit 47ed09b
Author: Brian Ingles <brianingles@deephaven.io>
Date:   Mon Sep 30 17:12:52 2024 -0500

    chore: Update dh packages to ^0.95.0 (deephaven#916)

    Update dh packages to ^0.95.0

    resolves deephaven#914

commit 5b0dce6
Author: Don <donmckenzie@deephaven.io>
Date:   Mon Sep 30 12:34:59 2024 -0400

    chore: remove errant comments (deephaven#915)

    Remove some accidental TODO comments that slipped in with a previous
    review

commit 5fb0ed5
Author: ethanalvizo <55671206+ethanalvizo@users.noreply.github.com>
Date:   Fri Sep 27 12:44:35 2024 -0400

    docs: flex pydocs (deephaven#912)

    Closes deephaven#824

    Separated from markdown docs in other flex
    [PR](deephaven#785)

commit 42315cf
Author: Matthew Runyon <matthewrunyon@deephaven.io>
Date:   Fri Sep 27 11:42:07 2024 -0500

    feat: Dataclass serialization support for deephaven UI (deephaven#897)

    Fixes deephaven#757

    I tested manually by creating my own dataclass with this code

    ```py
    import dataclasses

    @dataclasses.dataclass
    class Databar:
        column: str
        color: list[str] | None = None

    from deephaven import time_table, ui

    _t = time_table("PT1S").update(["X=ii", "Y=X", "Z=X", "A=X", "B=X", "C=X", "HalfX=X/2", "LogX=X > 0 ? log(X) : 0", "X2=X*2"])

    t = ui.table(_t, databars=[
        Databar(column="B"),
    ])
    ```

commit df5b17c
Author: Don <donmckenzie@deephaven.io>
Date:   Thu Sep 26 17:09:09 2024 -0400

    feat: allow overflow by default on ui.panel (deephaven#896)

    Fixes deephaven#178

    This improves the default layout experience across a number of layout
    cases. The primary goal was to allow overflow auto to happen on ui.panel
    by default while still filling space when passing multiple objects such
    as tables and plots.

    Tested across the cases in ui_flex.py, added e2e tests for those cases.

    Changes are as follows:
    - ui.panel has an overflow property, and defaults to auto
    - ui.grid now has default gap and flex auto
    - iris-grid has a min height of 70px to improve cases where it would
    normally shrink to 0
    - ui panel continues to wrap children by default in a flex with align
    start, but immediate flex children and grid have align-self stretch
    which is the normal default of a flex element
    - iris grid canvas has position absolute set so it doesn't actually
    impact flow

    BREAKING CHANGE: ui.panel now has overflow auto set by default and
    ui.grid now has default padding

commit 894dbc0
Author: Steven Wu <wusteven815@gmail.com>
Date:   Thu Sep 26 11:28:58 2024 -0400

    fix: dynamically update panel title (deephaven#906)

    - Fixes deephaven#318
      - Store the previous title to check if an update is needed
@ethanalvizo
Copy link
Contributor Author

#814 (comment)
@dsmmcken a comment from Matt regarding whether or not row/col behaviour should be mentioned in these flex docs

dsmmcken
dsmmcken requested changes Nov 1, 2024
View reviewed changes
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
@ethanalvizo ethanalvizo merged commit 54337d1 into deephaven:main Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaretkennedy margaretkennedy margaretkennedy approved these changes

@dsmmcken dsmmcken dsmmcken approved these changes

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.flex is missing many props now ui.flex is missing common props doc strings docs: ui.flex
4 participants
@ethanalvizo @mofojed @dsmmcken @margaretkennedy