-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI table formatting #950
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a66d448
WIP table formatting
mattrunyon 974187a
Refactor and support value formatting
mattrunyon eeb12de
Support theme colors, wildcards, and regex
mattrunyon 34f95e0
Remove regex and wildcard matching
mattrunyon 7301b7f
Add comments
mattrunyon b6ce3ac
Remove unused import
mattrunyon 4a9fe7a
Remove kw_only
mattrunyon cf13643
Fix test failures
mattrunyon c3e2e64
Merge branch 'main' into ui-table-formatting
mattrunyon 6724d80
Add docs
mattrunyon 277dfd9
Small refactor and reverse rule application order
mattrunyon 2b82923
Add unit tests
mattrunyon f47b271
Change where to condition
mattrunyon 8c55e99
Change props to format_ and if_
mattrunyon b4dc42b
Add e2e tests
mattrunyon a1f00ae
Merge branch 'main' into ui-table-formatting
mattrunyon 139e4c0
Merge branch 'main' into ui-table-formatting
mattrunyon beb1c1b
Change sphinx config for trailing underscore in param
mattrunyon 02c1e6c
Add error for if_ that is not a boolean
mattrunyon e18becc
Flesh out docs more
mattrunyon 778ee38
Address docs comments
mattrunyon 39d25ad
Add support for single rule without list
mattrunyon dd90946
Fix autocomplete of params
mattrunyon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a sections for each formatter? Helps both SEO and shows a functional example of how to accomplish each task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense to do
Formatting Colors
andFormatting Values
unless you want each of those sections to be 1 or 2 sentences. That feels like overkill to me to show someone what "changing the background color to red" does or "changing text alignment to left".I think formatting colors would explain what kind of color values you can use and what values can take colors.
Formatting values would link out to appropriate docs about value format strings (I think they're Java formatting strings, but need to verify)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting colors and Formatting values sound reasonable in terms of avoiding super short sections; however, if a user is likely to search "Formatting table dates" and similar, it might be worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up adding
Formatting Colors
as an h3 to describe you can (and should) use theme colors. Then text/background color as h4.For values I added an h3 for numeric and datetime