Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI Dialog and DialogTrigger Components #953

Merged
merged 43 commits into from
Nov 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
cacc961
Initial dialog trigger python
dgodinez-dh Oct 14, 2024
b929784
fix merge
dgodinez-dh Oct 21, 2024
139dfd8
dialog trigger props
dgodinez-dh Oct 21, 2024
0c5d190
hook up dialog trigger
dgodinez-dh Oct 21, 2024
d987c49
dialog python
dgodinez-dh Oct 21, 2024
538c870
default mobile type
dgodinez-dh Oct 21, 2024
8854513
hook up js
dgodinez-dh Oct 21, 2024
85cd401
fix dialog children
dgodinez-dh Oct 21, 2024
911f78b
fix trigger children type
dgodinez-dh Oct 21, 2024
30c46e1
fix merge
dgodinez-dh Oct 22, 2024
7967900
use flag
dgodinez-dh Oct 22, 2024
3d18f15
test flag
dgodinez-dh Oct 22, 2024
928674b
use flag md
dgodinez-dh Oct 22, 2024
d07f491
dialog design
dgodinez-dh Oct 22, 2024
e072c0c
fix on_dismiss callback
dgodinez-dh Oct 22, 2024
3fbf387
remove target ref
dgodinez-dh Oct 22, 2024
a16f975
fix type names
dgodinez-dh Oct 22, 2024
86af53c
initial dialog trigger design
dgodinez-dh Oct 22, 2024
9ef1da3
design
dgodinez-dh Oct 22, 2024
e61ecfa
initial dialog md
dgodinez-dh Oct 22, 2024
e032323
merge latest
dgodinez-dh Oct 23, 2024
c1c2642
dialog md
dgodinez-dh Oct 23, 2024
1fa0dbf
dialog sidebar
dgodinez-dh Oct 23, 2024
bed2d79
initali dialog trigger md
dgodinez-dh Oct 23, 2024
4bc7eba
dialog trigger md
dgodinez-dh Oct 23, 2024
95a4f0b
sidebar
dgodinez-dh Oct 23, 2024
b0e8ea4
Apply suggestions from code review
dgodinez-dh Oct 24, 2024
bb4f1ea
Apply suggestions from code review
dgodinez-dh Oct 25, 2024
84d6372
fix capitaliztion
dgodinez-dh Oct 25, 2024
3e9dbd5
link
dgodinez-dh Oct 25, 2024
7542d52
Apply suggestions from code review
dgodinez-dh Oct 25, 2024
bf67a17
fix descriptions
dgodinez-dh Oct 25, 2024
13e27f3
use callback in use flag
dgodinez-dh Oct 25, 2024
bacdfb8
merge latest
dgodinez-dh Oct 28, 2024
a636e85
use_boolean
dgodinez-dh Oct 28, 2024
0bf8115
update for tox
dgodinez-dh Oct 28, 2024
99d7334
change to union
dgodinez-dh Oct 28, 2024
89678de
use from future
dgodinez-dh Oct 28, 2024
9eac153
fix example
dgodinez-dh Oct 28, 2024
44dcdcd
update docs for use_boolean
dgodinez-dh Oct 28, 2024
cd55e91
merge latest
dgodinez-dh Oct 31, 2024
819e3cf
Update plugins/ui/src/deephaven/ui/hooks/use_boolean.py
dgodinez-dh Oct 31, 2024
d021d43
Apply suggestions from code review
dgodinez-dh Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/ui/src/deephaven/ui/hooks/use_boolean.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from .._internal import InitializerFunction, UpdaterFunction
jnumainville marked this conversation as resolved.
Show resolved Hide resolved
from typing import Callable, cast, Protocol, Tuple, overload
from typing import Callable, cast, Protocol, Tuple, overload, Union

from .use_state import use_state
from .use_callback import use_callback
Expand All @@ -22,13 +22,13 @@ def use_boolean() -> Tuple[bool, BooleanCallable]:

@overload
def use_boolean(
initial_value: bool | InitializerFunction[bool],
initial_value: Union[bool, InitializerFunction[bool]],
) -> Tuple[bool, BooleanCallable]:
...


def use_boolean(
initial_value: bool | InitializerFunction[bool] = False,
initial_value: Union[bool, InitializerFunction[bool]] = False,
) -> Tuple[bool, BooleanCallable]:
"""
Hook to add a boolean variable to your component. The variable will persist across renders.
Expand Down
Loading