Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: default tox to 3.8 #972

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

jnumainville
Copy link
Collaborator

fixes #965

Default to test with 3.8

Also adds other environments to run. A tiny bit more maintenance when we add/remove version support but useful for both the gh action and easily running different versions locally

@jnumainville jnumainville changed the title fix: fix: default tox to 3.8 Oct 29, 2024
@jnumainville jnumainville requested review from a team and mattrunyon and removed request for a team October 29, 2024 21:44
@jnumainville jnumainville marked this pull request as ready for review October 29, 2024 21:44
@mattrunyon
Copy link
Collaborator

I would change the PR title to test instead of fix

How does this affect users? Will tox install Python for you or should we update the readme to suggest what version of Python to install or suggest something to manage different Python versions?

I guess since it uses the versioned Python executable we could just recommend installing the specific version for testing.

@jnumainville jnumainville changed the title fix: default tox to 3.8 test: default tox to 3.8 Oct 30, 2024
@jnumainville
Copy link
Collaborator Author

jnumainville commented Oct 30, 2024

tox sets up an independent python installation so it doesn't matter which one is currently being used. What this does now is allow you to easily test with different versions
Currently, if you just run with tox -e py it will use whatever version you are using in your environment.
With this change, if you run tox -e py it will always run 3.8. You can also run specific other versions easily though, such as tox -e py3.9, tox -e py3.10 etc.

@mattrunyon
Copy link
Collaborator

Is there something I'm missing for tox to set up my Python version? I just ran tox -e py with this branch and it quit with "could not find python interpreter with spec(s): python3.8"

@jnumainville
Copy link
Collaborator Author

jnumainville commented Oct 30, 2024

Oh yeah, you do need to have whatever python version you're using already. I can add that note to the tox directions. I should expand on those anyways.
How you have that version is currently dependent on your setup though. Maybe we could standardize that.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jnumainville jnumainville merged commit 103c1e7 into deephaven:main Nov 5, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Python 3.8 for tox tests locally
2 participants