feat: ui.link #980
Merged
feat: ui.link #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmmcken
reviewed
Nov 1, 2024
plugins/ui/docs/components/link.md
Outdated
Comment on lines
102
to
105
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Should be good now.
dsmmcken
requested changes
Nov 1, 2024
dsmmcken
reviewed
Nov 1, 2024
mofojed
requested changes
Nov 1, 2024
mofojed
previously approved these changes
Nov 7, 2024
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
margaretkennedy
approved these changes
Nov 7, 2024
dsmmcken
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #977 and Closes #860
Need to clarify:
download,ping,href_lang,referrer_policy,router_optionssince they do not appear to be working in the spectrum implementation, and they do not seem super needed (given that this is meant to serve as a basic link component)