Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resize contextual help popup for widget error messages #995

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Nov 6, 2024

  • Default size was limited to just 250px, which is too small for this use case
  • Just set width to "auto" so it resizes to the contents
  • Tested with a bad widget and opening the contextual help error message:
from deephaven import ui

@ui.component
def ui_boom():
    raise Exception("Boom")

boom = ui_boom()

- Default size was limited to just 250px, which is too small for this use case
- Just set width to "auto" so it resizes to the contents
- Tested with a bad widget and opening the contextual help error message:
```python
from deephaven import ui

@ui.component
def ui_boom():
    raise Exception("Boom")

boom = ui_boom()
```
@mofojed mofojed requested a review from dsmmcken November 6, 2024 22:08
@mofojed mofojed self-assigned this Nov 6, 2024
plugins/ui/src/js/src/styles.scss Outdated Show resolved Hide resolved
Co-authored-by: Don <dsmmcken@gmail.com>
@mofojed mofojed requested a review from dsmmcken November 7, 2024 14:49
@mofojed mofojed merged commit 3a74733 into deephaven:main Nov 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants