Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Panel management #118

Merged
merged 40 commits into from
Sep 18, 2024
Merged

feat: Panel management #118

merged 40 commits into from
Sep 18, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Sep 5, 2024 •
edited
Loading

In this PR:

  • Added a DEEPHAVEN: PANELS view

    • Maps connections to server variables
    • Allows clicking on variables to open panels
    • Is subscribed to changes on server, so will also show variables created outside of the extension

  • Open panels now refresh when active theme changes

  • Removed auto focus of output panel (Don't show Deephaven output panel until first connection #130 to provide the proper fix

resolves #116

Base automatically changed from 116-panel-management to main September 6, 2024 14:01
@bmingles bmingles force-pushed the 116-2-panel-management branch 2 times, most recently from 02ea32a to 60f2b4b Compare September 6, 2024 14:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:55:49
 A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1809
should return custom settings: Empty configspassed ✅257
should return custom settings: Populated configspassed ✅148
should be able to load VSCodepassed ✅1158
should only be visible when a supported file type is active: test.groovypassed ✅2867
should only be visible when a supported file type is active: test.pypassed ✅1234
 A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles changed the base branch from main to 116-3-cleanup September 6, 2024 14:59
Base automatically changed from 116-3-cleanup to main September 6, 2024 15:02
@bmingles bmingles force-pushed the 116-2-panel-management branch 2 times, most recently from a071a32 to 038ea6c Compare September 6, 2024 18:57
@bmingles bmingles changed the base branch from main to 116-4-panel-controller September 6, 2024 18:57
@bmingles bmingles force-pushed the 116-2-panel-management branch 2 times, most recently from a28acf3 to b5673f0 Compare September 10, 2024 22:02
@bmingles bmingles changed the base branch from 116-4-panel-controller to 13-icon-font-generation September 10, 2024 22:03
@bmingles bmingles linked an issue Sep 11, 2024 that may be closed by this pull request
Panel Management #116
Closed
@bmingles bmingles marked this pull request as ready for review September 11, 2024 19:39
mofojed
mofojed approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to clean up JSDoc, but looks good

src/services/PanelService.ts Outdated Show resolved Hide resolved
@bmingles bmingles force-pushed the 116-2-panel-management branch 2 times, most recently from 18a5606 to aed8676 Compare September 17, 2024 21:16
Base automatically changed from 13-icon-font-generation to main September 18, 2024 15:01
bmingles and others added 27 commits September 18, 2024 11:15
@bmingles
Made event handlers private (#116-2)
afbe101
@bmingles
Added consoleType to cn node (#116-2)
76b90d1
@bmingles
dh icon font (#116-2)
cc6a9cb
@bmingles
Updated icon font (#116-2)
5a97d39
@bmingles
Fixed rebase (#116-2)
8c7f9d3
@bmingles
Updated table unicode icon (#116-2)
6d699cd
@bmingles
Don't steal focus with pip check terminal (#116-2)
f53de3e
@bmingles
Removed unused variable (#116-2)
ff32a1a
@bmingles
Removed commented out code (#116-2)
0b640ab
@bmingles
Refresh panels on theme change (#116-2)
2ac060d
@bmingles
Added a waitFor(0) (#116-2)
7936da2
@bmingles
Consolidated sorting (#116-2)
43ea53e
@bmingles
Changed types (#116-2)
d8d1fb7
@bmingles
Comments (#116-2)
323d066
@bmingles
Reorder (#116-2)
1587733
@bmingles
Delete panel (#116-2)
d032d61
@bmingles
Unit tests (#116-2)
85c627e
@bmingles
Fixed regression (#116-2)
880c728
@bmingles
Unit tests (#116-2)
6966319
@bmingles
Added cases to switch (#116-2)
c836e4f
@bmingles
Added comment (#116-2)
bc65bdd
@bmingles
Renamed vars (#116-2)
660e884
@bmingles
Unit tests (#116-2)
cacc985
@bmingles
Updated type + comments (#116-2)
3a539e8
@bmingles
Backed out broken pip servers (#116-2)
50df32d
@bmingles
Removed auto show panel for now (#116-2)
cdac84c
@bmingles @mofojed
Update src/services/PanelService.ts
2a1dc80 
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@bmingles bmingles merged commit 4569a36 into main Sep 18, 2024
3 checks passed
@bmingles bmingles deleted the 116-2-panel-management branch September 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panel Management
2 participants
@bmingles @mofojed