feat: Connect to DHE worker

[bmingles]

Initial DHE connection feature:

• Connect to configured DHE server
• Prompt for credentials
• Create / delete core+ workers (currently using default settings)
• Determine worker type to create based on active editor languageid
• Auto dispose on vscode restart

Testing

Setup

• Connect to VPN, and have an available DHE server (dev-sanluis is what I've been using)

  Note It can be helpful to open a Query Monitor on this server to see workers get created / destroyed via the extension in the steps that follow.

• Configure the DHE server in vscode user or workspace settings:

  {
    "deephaven.enterpriseServers": [
      "https://dev-sanluis.int.illumon.com:8123/"
    ],
  }

• Pull this branch, npm install packages, then f5 for debugging. It should automatically open another vscode instance. In that instance, open a vscode folder containing .py / .groovy scripts, or create a new one where files can be put (vscode should remember this folder the next time you run the debugger)

• Click the DH activity bar item. You should see your configured server in the list of "Running" servers:
  

• Click on the server to initiate login flow. Provide credentials

• A worker should be created (should see it loading in the CONNECTIONS panel
  

• Create a new python file with a simple script:

  from deephaven import time_table
  
  simple_ticking = time_table("PT2S")

• Run it using double arrows at top of file.

• If you don't have any other configured, running server, it should automatically connect to the worker you started. Otherwise, you will be prompted to select your connection
  

• To discard the worker, you cal use the trash icon in the connection tree item

  

[github-actions]

End-to-end Test Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
6	6	0	0	0	0	0	04:46:22

A ctrf plugin

Detailed Test Results

Name	Status	ms	Flaky 🍂
should default to the correct settings	passed ✅	2040
should return custom settings: Empty configs	passed ✅	252
should return custom settings: Populated configs	passed ✅	101
should be able to load VSCode	passed ✅	925
should only be visible when a supported file type is active: test.groovy	passed ✅	2849
should only be visible when a supported file type is active: test.py	passed ✅	1041

A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

[vbabich]

I don't know if it matters in your case, but known configs may be not fully populated on login. The client fires configadded for each of the remaining queries.

[bmingles]

getWorkerInfoFromQuery calls this function in response to EVENT_CONFIG_UPDATED events until it finds a match. Should that work, or does EVENT_CONFIG_ADDED need to be accounted for as well?

[vbabich]

Scanning all known configs on each update can be problematic with something like 10k+ queries since the update event is fired multiple times in the query lifecycle.
I think EVENT_CONFIG_ADDED needs to be handled instead of EVENT_CONFIG_UPDATED. Also check if event.details have the info you need so you don't have to re-scan the known configs.

[bmingles]

IIR, I had originally tried that one, but the worker url wasn't available when it was added. It only showed up after a future update. I could be misremembering though.

[vbabich]

Right, that seems possible. Was the worker URL eventually available in the update event details?

[bmingles]

yes

[vbabich]

It seems possible to create an IC query with an arbitrary scheduling type, though Charles mentioned it should be Temporary scheduling with the InteractiveConsoleTemporaryQueue queue name. See make_temporary_config for more details - https://docs.deephaven.io/pycoreplus/20240517/_modules/deephaven_enterprise/client/controller.html#ControllerClient.make_temporary_config

[bmingles]

@vbabich
Looks like that calls:https://docs.deephaven.io/pycoreplus/20240517/_modules/deephaven_enterprise/client/generate_scheduling.html#GenerateScheduling.generate_temporary_scheduler

Does that mean instead of calling makeDefaultScheduling, we'd want to add a new method like makeTemporaryScheduling and return an array of key=value tokens similar to generate_temporary_scheduler?

[bmingles]

I've created a PR based on the referenced code that "should" give us a comparable temporary schedule in the JS client:
https://github.com/deephaven-ent/iris/pull/2348

[vbabich]

Yes, makeDefaultScheduling generates the scheduling config for new Script type queries I'd add a function for temporary scheduling.

[vbabich]

EVENT_CONFIG_UPDATED is fired fairly often and scanning known configs can be problematic on large query sets. I'd do an initial findQueryConfigForSerial and subscribe to the update event if the info object with the URL isn't found.

[vbabich]

A couple of notes:

• addEventListener returns a callback remover. Need to remove the listener on resolve/reject.
• the Promise gets stuck in Pending if the query is created but ends up in a Failed state. Might need to check if the query status is one of the valid startup statuses.

[bmingles]

Added to Connection / event handler cleanup #152