Skip to content

Commit

Permalink
fix: Plugin peer dependencies do not get versions from lerna (#1517)
Browse files Browse the repository at this point in the history
Apparently lerna doesn't treat `file` items in peer dependencies the
same as it does for regular or dev dependencies. They don't get replaced
and make the peer dependency unfindable.

Compare these 2. In peer dependencies for plugin it lists
`file:../dashboard` instead of an actual version. But for regular
dependencies in components, they get a version.

https://unpkg.com/@deephaven/plugin@0.48.0/package.json
https://unpkg.com/@deephaven/components@0.48.0/package.json
  • Loading branch information
mattrunyon authored Sep 15, 2023
1 parent a1de0f6 commit 322f6ff
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
14 changes: 9 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"build": "cross-env NODE_ENV=production run-p build:*",
"build:babel": "babel ./src --out-dir ./dist --extensions \".ts,.tsx,.js,.jsx\" --source-maps --root-mode upward"
},
"peerDependencies": {
"dependencies": {
"@deephaven/components": "file:../components",
"@deephaven/iris-grid": "file:../iris-grid",
"@deephaven/jsapi-types": "file:../jsapi-types"
Expand Down

0 comments on commit 322f6ff

Please sign in to comment.