fix: Allow JSX.Element to be passed into a context action title

- We already supported it, but we just didn't allow the type
deephaven · Sep 18, 2024 · 4d094b0 · 4d094b0
1 parent 96e3d43
commit 4d094b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/components/src/context-actions/ContextActionUtils.ts b/packages/components/src/context-actions/ContextActionUtils.ts
@@ -10,7 +10,7 @@ export type ResolvableContextAction =
 export type MenuItem = ContextAction | Promise<ContextAction[]>;
 
 export interface ContextAction {
- title?: string;
+ title?: string | JSX.Element;
  description?: string;
  action?: (event: Event) => void;
  actions?: ResolvableContextAction[];

diff --git a/packages/dashboard-core-plugins/src/panels/Panel.tsx b/packages/dashboard-core-plugins/src/panels/Panel.tsx
@@ -13,6 +13,7 @@ import {
  ContextActions,
  createXComponent,
  LoadingOverlay,
+ ResolvableContextAction,
  Tooltip,
 } from '@deephaven/components';
 import { LayoutUtils, PanelComponent, PanelEvent } from '@deephaven/dashboard';
@@ -60,7 +61,7 @@ export type CorePanelProps = {
  onTabBlur?: (...args: unknown[]) => void;
  onTabFocus?: (...args: unknown[]) => void;
  renderTabTooltip?: () => ReactNode;
- additionalActions?: ContextAction[];
+ additionalActions?: ResolvableContextAction[];
  errorMessage?: string;
  isLoading?: boolean;
  isLoaded?: boolean;