Skip to content

Commit

Permalink
ci: Enable tests on feature branches (#2007)
Browse files Browse the repository at this point in the history
- We were not running tests on feature branches
  • Loading branch information
mofojed authored May 13, 2024
1 parent 3236c9b commit 7d59d09
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ on:
branches:
- main
- 'release/**'
- 'feature/**'
pull_request:
branches:
- main
- 'release/**'
- 'feature/**'
env:
DOCKER_TAG: edge

jobs:

build:
runs-on: ubuntu-22.04
concurrency:
Expand Down Expand Up @@ -81,7 +82,6 @@ jobs:
run: |
docker pull --quiet ghcr.io/deephaven/server:${{ env.DOCKER_TAG }}
docker run --detach --publish 10000:10000 --name dh-core-server -v ./tests/docker-scripts/data:/data --env "START_OPTS=-Xmx4g -DAuthHandlers=io.deephaven.auth.AnonymousAuthenticationHandler -Ddeephaven.application.dir=./data/app.d" ghcr.io/deephaven/server:${{ env.DOCKER_TAG }}
- name: Cache node modules
id: cache-node-modules
Expand Down Expand Up @@ -112,8 +112,7 @@ jobs:
echo "shardTotal=${MATRIX_CONFIG: -1:1}" >> $GITHUB_OUTPUT
- name: Run Playwright tests
run:
PLAYWRIGHT_BROWSERS_PATH=0 npx playwright test --config=playwright-ci.config.ts --reporter=blob --project=${{ steps.config.outputs.browser }} --shard=${{ steps.config.outputs.shard }}/${{ steps.config.outputs.shardTotal }}
run: PLAYWRIGHT_BROWSERS_PATH=0 npx playwright test --config=playwright-ci.config.ts --reporter=blob --project=${{ steps.config.outputs.browser }} --shard=${{ steps.config.outputs.shard }}/${{ steps.config.outputs.shardTotal }}

- name: Upload Playwright report
uses: actions/upload-artifact@v4
Expand All @@ -122,7 +121,7 @@ jobs:
name: playwright-report-blob-${{ matrix.config }}
path: blob-report/
retention-days: 1

- name: Dump server logs
if: failure()
run: docker logs dh-core-server > /tmp/server-log.txt
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ on:
branches:
- main
- 'release/**'
- 'feature/**'
pull_request:
branches:
- main
- 'release/**'
- 'feature/**'
jobs:
unit:
runs-on: ubuntu-22.04
Expand Down

0 comments on commit 7d59d09

Please sign in to comment.