Skip to content

Commit

Permalink
fix: e2e test status reporting incorrectly (#2045)
Browse files Browse the repository at this point in the history
Fixes #2044

Infra PR deephaven/infra#301

You can see the e2e-results job failed on my 2nd commit to this PR. It
should fail if any of the matrix jobs fail or are cancelled.
  • Loading branch information
mattrunyon committed May 30, 2024
1 parent 0e22d11 commit 8e6b6da
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,12 @@ jobs:
name: playwright-report
path: playwright-report
retention-days: 30

e2e-results:
if: ${{ always() }}
runs-on: ubuntu-22.04
needs: [e2e-tests]
steps:
- name: Fail if any tests failed or cancelled
run: exit 1
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}

0 comments on commit 8e6b6da

Please sign in to comment.