Fixed boolean mapping (#1858)

deephaven · Mar 26, 2024 · a46b687 · a46b687
1 parent 3b7e8e7
commit a46b687
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/__mocks__/dh-core.js b/__mocks__/dh-core.js
@@ -1990,8 +1990,10 @@ class SourceType {
 }
 
 class ValueType {
-  static CHAR = 'CHAR';
+  static BOOLEAN = 'BOOLEAN';
   static DATETIME = 'DATETIME';
+  static DOUBLE = 'DOUBLE';
+  static LONG = 'LONG';
   static NUMBER = 'NUMBER';
   static STRING = 'STRING';
 }

diff --git a/packages/jsapi-utils/src/TableUtils.test.ts b/packages/jsapi-utils/src/TableUtils.test.ts
@@ -575,10 +575,9 @@ describe('executeAndWaitForEvent', () => {
 
 describe('getValueType', () => {
   it.each([
-    // TODO: Is there a better mapping for boolean?
-    ['boolean', dh.ValueType.STRING],
-    ['java.lang.Boolean', dh.ValueType.STRING],
-    [TableUtils.dataType.BOOLEAN, dh.ValueType.STRING],
+    ['boolean', dh.ValueType.BOOLEAN],
+    ['java.lang.Boolean', dh.ValueType.BOOLEAN],
+    [TableUtils.dataType.BOOLEAN, dh.ValueType.BOOLEAN],
 
     ['char', dh.ValueType.STRING],
     ['java.lang.Character', dh.ValueType.STRING],

diff --git a/packages/jsapi-utils/src/TableUtils.ts b/packages/jsapi-utils/src/TableUtils.ts
@@ -877,7 +877,7 @@ export class TableUtils {
   }
 
   /**
-   * Get the `dh.ValueType` correspoding to the given `dh.Column.type` value.
+   * Get the `dh.ValueType` corresponding to the given `dh.Column.type` value.
    * @param columnType The column type to get the value type for
    * @returns The `dh.ValueType` corresponding to the column type
    */
@@ -889,6 +889,9 @@ export class TableUtils {
     const columnDataType = TableUtils.getNormalizedType(columnType);
 
     switch (columnDataType) {
+      case TableUtils.dataType.BOOLEAN:
+        return this.dh.ValueType.BOOLEAN;
+
       case TableUtils.dataType.CHAR:
       case TableUtils.dataType.STRING:
         return this.dh.ValueType.STRING;