modify based off PR comments

deephaven · Sep 21, 2024 · c2114da · c2114da
1 parent 64f50bd
commit c2114da
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/packages/code-studio/src/styleguide/CheckboxGroups.tsx b/packages/code-studio/src/styleguide/CheckboxGroups.tsx
@@ -12,16 +12,16 @@ export function CheckboxGroups(): JSX.Element {
         <Flex direction="column">
           <Text>Single Child</Text>
           <CheckboxGroup aria-label="Single Child">
-            <Checkbox>Aaa</Checkbox>
+            <Checkbox value="Aaa">Aaa</Checkbox>
           </CheckboxGroup>
         </Flex>
 
         <Flex direction="column">
           <Text>Multiple Children</Text>
           <CheckboxGroup aria-label="Multiple Children">
-            <Checkbox>Aaa</Checkbox>
-            <Checkbox>Bbb</Checkbox>
-            <Checkbox>Ccc</Checkbox>
+            <Checkbox value="Aaa">Aaa</Checkbox>
+            <Checkbox value="Bbb">Bbb</Checkbox>
+            <Checkbox value="Ccc">Ccc</Checkbox>
           </CheckboxGroup>
         </Flex>
 

diff --git a/packages/components/src/spectrum/CheckboxGroup.tsx b/packages/components/src/spectrum/CheckboxGroup.tsx
@@ -22,17 +22,11 @@ export function CheckboxGroup({
 }: CheckboxGroupProps): JSX.Element {
   const wrappedChildren = useMemo(
     () =>
-      ensureArray(children).map((child, index) =>
+      ensureArray(children).map(child =>
         isElementOfType(child, Checkbox) ? (
-          React.cloneElement(child, {
-            key: `${index}-${String(child)}`,
-            value: `${index}-${String(child)}`,
-          })
+          child
         ) : (
-          <Checkbox
-            key={`${index}-${String(child)}`}
-            value={`${index}-${String(child)}`}
-          >
+          <Checkbox key={String(child)} value={String(child)}>
             {String(child)}
           </Checkbox>
         )