feat: reopen closed tabs (#1912)

- Add #1785 - Add keyboard shortcut (Alt+Shift+A) to reopen last closed tab
deephaven · Apr 11, 2024 · c2e8714 · c2e8714
1 parent 9b14ee0
commit c2e8714
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 0 deletions.
diff --git a/packages/code-studio/src/main/AppMainContainer.tsx b/packages/code-studio/src/main/AppMainContainer.tsx
@@ -234,6 +234,13 @@ export class AppMainContainer extends Component<
  shortcut: IRIS_GRID_SHORTCUTS.TABLE.CLEAR_ALL_FILTERS,
  isGlobal: true,
  },
+ {
+ action: () => {
+ this.sendReopenLast();
+ },
+ shortcut: GLOBAL_SHORTCUTS.REOPEN_CLOSED_PANEL,
+ isGlobal: true,
+ },
  {
  action: () => {
  log.debug('Consume unhandled save shortcut');
@@ -402,6 +409,10 @@ export class AppMainContainer extends Component<
  this.emitLayoutEvent(InputFilterEvent.CLEAR_ALL_FILTERS);
  }
 
+ sendReopenLast(): void {
+ this.emitLayoutEvent(PanelEvent.REOPEN_LAST);
+ }
+
  emitLayoutEvent(event: string, ...args: unknown[]): void {
  const { activeTabKey } = this.state;
  const layout = this.dashboardLayouts.get(activeTabKey);

diff --git a/packages/components/src/shortcuts/GlobalShortcuts.ts b/packages/components/src/shortcuts/GlobalShortcuts.ts
@@ -30,6 +30,13 @@ const GLOBAL_SHORTCUTS = {
  macShortcut: [MODIFIER.CMD, KEY.A],
  isEditable: false,
  }),
+ REOPEN_CLOSED_PANEL: ShortcutRegistry.createAndAdd({
+ id: 'GLOBAL.REOPEN_CLOSED_PANEL',
+ name: 'Re-open Closed Panel',
+ shortcut: [MODIFIER.ALT, MODIFIER.SHIFT, KEY.T],
+ macShortcut: [MODIFIER.OPTION, MODIFIER.SHIFT, KEY.T],
+ isEditable: true,
+ }),
  LINKER: ShortcutRegistry.createAndAdd({
  id: 'GLOBAL.LINKER',
  name: 'Linker',

diff --git a/packages/dashboard/src/PanelEvent.ts b/packages/dashboard/src/PanelEvent.ts
@@ -32,6 +32,9 @@ export default Object.freeze({
  // Panel was re-opened from a dehydrated state
  REOPEN: 'PanelEvent.REOPEN',
 
+ // Reopen last closed panel
+ REOPEN_LAST: 'PanelEvent.REOPEN_LAST',
+
  // Panel was deleted
  DELETE: 'PanelEvent.DELETE',
 

diff --git a/packages/dashboard/src/PanelManager.ts b/packages/dashboard/src/PanelManager.ts
@@ -82,6 +82,7 @@ class PanelManager {
  // and PanelEvent.CLOSED for cleanup (delete links, add panel to closed panels list, etc)
  this.handleUnmount = this.handleUnmount.bind(this);
  this.handleReopen = this.handleReopen.bind(this);
+ this.handleReopenLast = this.handleReopenLast.bind(this);
  this.handleDeleted = this.handleDeleted.bind(this);
  this.handleClosed = this.handleClosed.bind(this);
  this.handleControlClose = this.handleControlClose.bind(this);
@@ -106,6 +107,7 @@ class PanelManager {
  eventHub.on(PanelEvent.MOUNT, this.handleMount);
  eventHub.on(PanelEvent.UNMOUNT, this.handleUnmount);
  eventHub.on(PanelEvent.REOPEN, this.handleReopen);
+ eventHub.on(PanelEvent.REOPEN_LAST, this.handleReopenLast);
  eventHub.on(PanelEvent.DELETE, this.handleDeleted);
  eventHub.on(PanelEvent.CLOSED, this.handleClosed);
  eventHub.on(PanelEvent.CLOSE, this.handleControlClose);
@@ -118,6 +120,7 @@ class PanelManager {
  eventHub.off(PanelEvent.MOUNT, this.handleMount);
  eventHub.off(PanelEvent.UNMOUNT, this.handleUnmount);
  eventHub.off(PanelEvent.REOPEN, this.handleReopen);
+ eventHub.off(PanelEvent.REOPEN_LAST, this.handleReopenLast);
  eventHub.off(PanelEvent.DELETE, this.handleDeleted);
  eventHub.off(PanelEvent.CLOSED, this.handleClosed);
  eventHub.off(PanelEvent.CLOSE, this.handleControlClose);
@@ -291,6 +294,11 @@ class PanelManager {
  LayoutUtils.openComponent({ root, config, replaceConfig });
  }
 
+ handleReopenLast(): void {
+ if (this.closed.length === 0) return;
+ this.handleReopen(this.closed[this.closed.length - 1]);
+ }
+
  handleDeleted(panelConfig: ClosedPanel): void {
  log.debug2('Deleted:', panelConfig);