Addressed code review comments (#2222)

deephaven · Sep 18, 2024 · f969947 · f969947
1 parent 288d2bc
commit f969947
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/components/src/BulkActionBar.tsx b/packages/components/src/BulkActionBar.tsx
@@ -1,7 +1,13 @@
-import type { StyleProps } from '@react-types/shared';
+import type { ItemElement, StyleProps } from '@react-types/shared';
 import { ActionBar } from './spectrum';
 import commonStyles from './SpectrumComponent.module.scss';
 
+// The action bar will still show the item count + a clear selection button
+// even if there are no actions. Our only consumer is currently the ACL Editor,
+// but group action functionality has not yet been prioritized (see DH-15221).
+// For now we'll just pass it an empty action items array.
+const noActions: ItemElement<unknown>[] = [];
+
 export interface BulkActionBarProps {
   styleProps?: StyleProps;
   selectedItemCount: 'all' | number;
@@ -22,7 +28,7 @@ export function BulkActionBar({
       selectedItemCount={selectedItemCount}
       onClearSelection={onClearSelection}
     >
-      <span />
+      {noActions}
     </ActionBar>
   );
 }

diff --git a/packages/log/src/LogProxy.ts b/packages/log/src/LogProxy.ts
@@ -124,7 +124,6 @@ export class LogProxy {
     type: LOG_PROXY_TYPE,
     listener: (event: CustomEvent<unknown[]>) => void
   ): void {
-    // The cast as EventListener is a dumb TypeScript issue
     this.eventTarget.addEventListener(
       type,
       listener as Parameters<EventTarget['addEventListener']>[1]