Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: "Group" column for rollup/tree tables #1636

Merged
merged 15 commits into from
Dec 15, 2023
Merged

feat: "Group" column for rollup/tree tables #1636

merged 15 commits into from
Dec 15, 2023

Commits on Dec 15, 2023

  1. feat: Show rollup grouping values only on the 'rolled-up' row

    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    339c972 View commit details
    Browse the repository at this point in the history

  2. Memoize the columns and grouped columns

    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    30e76c2 View commit details
    Browse the repository at this point in the history

  3. Don't allow filtering on the Group column

    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    98918d4 View commit details
    Browse the repository at this point in the history

  4. Have the context menu open up the appropriate filter options for that… 

    … cell

- Proxies to getting the menu items from the actual cell
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    94e7958 View commit details
    Browse the repository at this point in the history

  5. Don't proxy data for consistituent group rows 

    - It was duplicating the constituent data, which was not what we wanted
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9775941 View commit details
    Browse the repository at this point in the history

  6. WIP make the Clear Column Filter work 

    - Can clear column filter from line up
- Should actually clear _all_ group filters and have a different name...
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2f54eff View commit details
    Browse the repository at this point in the history

  7. Add a getClearFilterRange method on IrisGridModel 

    - Returns the range of columns that should be cleared when clearing the filter on this column
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    bebd1f1 View commit details
    Browse the repository at this point in the history

  8. Update snapshots

    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2a74c59 View commit details
    Browse the repository at this point in the history

  9. Update docs based on review

    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a4d3ca3 View commit details
    Browse the repository at this point in the history

  10. Change name of virtual column 

    - "Key column" is more descriptive
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    73cc8d8 View commit details
    Browse the repository at this point in the history

  11. Cleanup based on review 

    - Add support for `DisplayColumn` with a `displayName` prop
- Clean up some comments
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f443c5c View commit details
    Browse the repository at this point in the history

  12. Clean up based on review 

    - Just some minor cleanup
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    2a4d61d View commit details
    Browse the repository at this point in the history

  13. Get the sourceColumn working with totals correctly 

    - Now it doesn't crash when you add aggregations
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0802c56 View commit details
    Browse the repository at this point in the history

  14. Fix up based on review 

    - Don't show the proxy column in the Organize Columns, Search Columns, or aggregations sections
- Fix an issue with rehydrating tree tables with an aggregation set (table.size can be negative on initial load)
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a4a55eb View commit details
    Browse the repository at this point in the history

  15. Don't allow linking to/from proxy columns 

    - It just gets weird
    @mofojed
    mofojed committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8187250 View commit details
    Browse the repository at this point in the history