-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: figure_title
and chart_title
were not mapped up correctly
#1676
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 46.65% 46.67% +0.02%
==========================================
Files 606 606
Lines 36852 36873 +21
Branches 9255 9267 +12
==========================================
+ Hits 17192 17211 +19
- Misses 19608 19610 +2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think we need to still support this behaviour as that's what our docs said to use, so people have been using chart_title like it was figure_title. Maybe only in the case where figure_title is null or chart_title count == 1 or something. |
- We currently were showing the first charts title as the figure title
- Needed to add annotations for it - Fixes deephaven#1675
- Fallback to chart title if there is only one chart and the figure title is not set - Use `yshift` property to position the text correctly regardless of size of plot
c5a47a0
to
9ee6592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just want to confirm w/ @dsmmcken that the chart title spacing is good (it's consistent now regardless of panel size)
Spacing is fine |
annotations
to get it to work correctlyFigure().figure_title()
does not render a title in the IDE or in Jupyter #1674 , Fixeschart_title
doesn't title subplots #1675