Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Picker - Table support for key + label columns #1876

Merged
merged 40 commits into from
Mar 27, 2024

Logger namespace (#1858)

4b70ed0
Select commit
Loading
Failed to load commit list.
Merged

feat: Picker - Table support for key + label columns #1876

Logger namespace (#1858)
4b70ed0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2024 in 0s

46.20% (+0.09%) compared to 78c1af1

View this Pull Request on Codecov

46.20% (+0.09%) compared to 78c1af1

Details

Codecov Report

Attention: Patch coverage is 68.13187% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 46.20%. Comparing base (78c1af1) to head (4b70ed0).

Files Patch % Lines
...es/jsapi-components/src/spectrum/Picker/Picker.tsx 0.00% 29 Missing ⚠️
packages/components/src/spectrum/picker/Picker.tsx 0.00% 24 Missing ⚠️
packages/jsapi-utils/src/TableUtils.ts 85.71% 3 Missing ⚠️
packages/code-studio/src/styleguide/Pickers.tsx 80.00% 1 Missing ⚠️
packages/utils/src/TestUtils.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
+ Coverage   46.11%   46.20%   +0.09%     
==========================================
  Files         637      641       +4     
  Lines       38054    38216     +162     
  Branches     9620     9671      +51     
==========================================
+ Hits        17549    17659     +110     
- Misses      20452    20504      +52     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.