Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-17199: Filter by value in the tree table context menu always shows null #2078

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Jun 13, 2024

Provide an initializer for the optional formatValue argument in IrisGridTreeTableModel snapshot method.
Remove the conditional that caused the resultRow to be an empty array when the formatValue argument isn't provided.

@vbabich vbabich requested a review from mofojed June 13, 2024 20:24
@vbabich vbabich self-assigned this Jun 13, 2024
@vbabich vbabich added this to the June 2024 milestone Jun 13, 2024
@vbabich vbabich marked this pull request as ready for review June 13, 2024 20:25
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (640e002) to head (05ed7ca).

Files Patch % Lines
packages/iris-grid/src/IrisGridTreeTableModel.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
- Coverage   46.60%   46.60%   -0.01%     
==========================================
  Files         677      677              
  Lines       38564    38565       +1     
  Branches     9769     9769              
==========================================
  Hits        17974    17974              
- Misses      20538    20539       +1     
  Partials       52       52              
Flag Coverage Δ
unit 46.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich enabled auto-merge (squash) June 13, 2024 20:27
@vbabich vbabich added the bug Something isn't working label Jun 13, 2024
@vbabich vbabich merged commit 4eb38dd into deephaven:main Jun 13, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@vbabich vbabich deleted the fix_format_value branch June 14, 2024 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants