Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TablePlugin needs to know table name and selected range #2181

Merged

Conversation

AkshatJawne
Copy link
Contributor

Resolves #2093

@AkshatJawne AkshatJawne self-assigned this Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (1d51585) to head (f2c36e1).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
- Coverage   46.67%   46.64%   -0.03%     
==========================================
  Files         692      692              
  Lines       38620    38581      -39     
  Branches     9625     9844     +219     
==========================================
- Hits        18025    17998      -27     
+ Misses      20584    20530      -54     
- Partials       11       53      +42     
Flag Coverage Δ
unit 46.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@AkshatJawne AkshatJawne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mofojed I just passed the tableName and selectedRanges props down to the plugin, was there anything specific you were wanting here, in terms of a "better way" to handle the prop?

@AkshatJawne AkshatJawne marked this pull request as ready for review August 13, 2024 13:54
Copy link
Contributor Author

@AkshatJawne AkshatJawne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for re-review @mofojed

@AkshatJawne AkshatJawne merged commit 0b37477 into deephaven:main Aug 15, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TablePlugin needs to know current grid selection, table name
2 participants