Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors thrown during a grid update are not caught #2188

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mattrunyon
Copy link
Collaborator

Errors thrown during a requestAnimationFrame are not caught because they're thrown from a separate stack than the component. This means any render method that throws after the first grid render won't actually be caught and the grid will potentially draw incorrectly.

@mattrunyon mattrunyon self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.67%. Comparing base (5f9cf7f) to head (2ade1a4).

Files Patch % Lines
packages/grid/src/Grid.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
- Coverage   46.67%   46.67%   -0.01%     
==========================================
  Files         692      692              
  Lines       38630    38635       +5     
  Branches     9630     9631       +1     
==========================================
+ Hits        18029    18031       +2     
- Misses      20590    20593       +3     
  Partials       11       11              
Flag Coverage Δ
unit 46.67% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit 2e59b92 into deephaven:main Aug 14, 2024
11 checks passed
@mattrunyon mattrunyon deleted the grid-render-error-fix branch August 14, 2024 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants