Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change TabEvent to object literal, add TabEventMap #2191

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Aug 15, 2024

Add TabEventMap associating TabEvent types to callback signatures.
Change TabEvent to object literal so it could be used to define TabEventMap.

BREAKING CHANGE: Delete unused event types: openPQObject, openControl, reload, clearAllFilters.

@vbabich vbabich self-assigned this Aug 15, 2024
@vbabich vbabich requested a review from mofojed August 15, 2024 18:55
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (a257296) to head (793abb6).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
- Coverage   46.66%   46.64%   -0.03%     
==========================================
  Files         692      692              
  Lines       38629    38578      -51     
  Branches     9814     9821       +7     
==========================================
- Hits        18028    17995      -33     
- Misses      20548    20572      +24     
+ Partials       53       11      -42     
Flag Coverage Δ
unit 46.64% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich changed the title chore: Change TabEvent to object literal, add TabEventMap refactor: Change TabEvent to object literal, add TabEventMap Aug 15, 2024
@vbabich vbabich enabled auto-merge (squash) August 16, 2024 16:40
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@vbabich vbabich requested a review from mofojed August 20, 2024 20:01
@vbabich vbabich merged commit 419f95d into deephaven:main Aug 20, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants