Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DH-17454: Fix Spectrum component theming in modal dialogs #2197

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: DH-17454: Fix Spectrum component theming in modal dialogs #2197

merged 2 commits into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. fix: DH-17454: Combine modal classes instead of replacing (deephaven#… 

    …2173)
    @vbabich
    vbabich committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b5739a4 View commit details
    Browse the repository at this point in the history

  2. fix: DH-17454: Wrap Modal in SpectrumThemeProvider (deephaven#2169) 

    Wrap the `Modal` component attached to `document.body` in
`SpectrumThemeProvider`.

Had to add `zIndex: 0` and `position: relative` to the
`SpectrumThemeProvider` to fix the issue with `DatePicker` popovers
nested in the `Modal` rendering behind it.

![Screenshot 2024-07-23 at 4 35
35 PM](https://github.com/user-attachments/assets/1a860697-f4dd-4565-bf0e-6269f24a8723)
    @vbabich
    vbabich committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6610162 View commit details
    Browse the repository at this point in the history