refactor: Remove @adobe/react-spectrum imports where prohibited #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
========================================
Coverage 46.64% 46.65%
========================================
Files 692 692
Lines 38581 38583 +2
Branches 9820 9637 -183
========================================
+ Hits 17998 18000 +2
- Misses 20530 20572 +42
+ Partials 53 11 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
reviewed
Aug 23, 2024
bmingles
approved these changes
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195
Had to just ignore some of the errors because we compare spectrum components in the styleguide and I didn't want to mess with that for now.
I still think it's a bit confusing that there are things in
components/src/spectrumthat aren't pure re-exports (e.g. ComboBox). Makes it confusing to know which to use.