Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid import in @deephaven/components for webpack #2200

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Aug 26, 2024

Fixes #2192

Tested by following steps in the ticket. Created a react app w/ create-react-app and installed @deephaven/components@0.91.1-webpack-fix.0 (alpha build from this PR). It properly started without webpack errors.

@mattrunyon mattrunyon self-assigned this Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (336e1f3) to head (424a5ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2200   +/-   ##
=======================================
  Coverage   46.64%   46.64%           
=======================================
  Files         692      692           
  Lines       38571    38571           
  Branches     9647     9647           
=======================================
  Hits        17992    17992           
  Misses      20568    20568           
  Partials       11       11           
Flag Coverage Δ
unit 46.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon marked this pull request as ready for review August 26, 2024 20:23
@mattrunyon mattrunyon merged commit dcc95f6 into deephaven:main Aug 30, 2024
12 checks passed
@mattrunyon mattrunyon deleted the components-webpack-fix branch August 30, 2024 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@deephaven/components does not work with webpack
2 participants