fix: Widget panel fixes #2227
Merged
fix: Widget panel fixes #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Sep 18, 2024
•
mofojed
commented
- Allow JSX.Element to be passed into a context action title
- We already supported it, but we just didn't allow the type
- Reset isDisconnected flag when the model is initialized
- On reconnect, the model was reloading but it was staying in a "disconnected" state
- We already supported it, but we just didn't allow the type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
=======================================
Coverage 46.61% 46.61%
=======================================
Files 692 692
Lines 38508 38508
Branches 9826 9802 -24
=======================================
Hits 17949 17949
Misses 20506 20506
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Use ResolvableContextAction instead of just ContextAction - Clean up unused imports
vbabich
previously approved these changes
Sep 19, 2024
- Was just staying in a disconnected state even though the table/charts had reloaded
mofojed
changed the title
vbabich
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.