-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ruff Python formatter and linter #2233
Merged
Merged
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2bf15a9 - Browse repository at this point
Copy the full SHA 2bf15a9View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aaf4325 - Browse repository at this point
Copy the full SHA aaf4325View commit details
Commits on Sep 20, 2024
-
feat: Ruff Configuration Settings (#2215)
Fixes #1255 I need to test this doesn't crash if using groovy. Not sure if the ruff version is available without initializing ruff first or what happens if it's unavailable. - Added global setting for minimap, format on save, formatter, and formatting settings - Added format on save option and format button to notebook overflow menu - Format on save triggers on both shortcut and pressing the save button - Config editor has JSON schema included - Config editor cannot be closed by clicking outside the modal, but can be closed w/ escape key Something we should add maybe as part of this PR or a final follow-up to this feature branch is disabling certain/all linting/formatting for the console. One way we might do this is by registering the console w/ a specific URI or URI scheme so we can check it when checking if we should lint. Or include it as a prop to the `MonacoProviders` component. This would require some changes to the current setup of setting/using the config on `MonacoProviders` static members/methods (This might not actually be breaking, it's more just notes for implementing in DHE) BREAKING CHANGE: The app should call `MonacoUtils.init` with a `getWorker` function that uses the JSON worker in addition to the general fallback worker when adding support for configuring ruff.
Configuration menu - View commit details
-
Copy full SHA for 3144edb - Browse repository at this point
Copy the full SHA 3144edbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f606c0a - Browse repository at this point
Copy the full SHA f606c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b89ed9 - Browse repository at this point
Copy the full SHA 0b89ed9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ba240 - Browse repository at this point
Copy the full SHA 25ba240View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2778f27 - Browse repository at this point
Copy the full SHA 2778f27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.