Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ruff Python formatter and linter #2233

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    2bf15a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    aaf4325 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. feat: Ruff Configuration Settings (#2215)

    Fixes #1255 
    
    I need to test this doesn't crash if using groovy. Not sure if the ruff
    version is available without initializing ruff first or what happens if
    it's unavailable.
    
    - Added global setting for minimap, format on save, formatter, and
    formatting settings
    - Added format on save option and format button to notebook overflow
    menu
    - Format on save triggers on both shortcut and pressing the save button
    - Config editor has JSON schema included
    - Config editor cannot be closed by clicking outside the modal, but can
    be closed w/ escape key
    
    Something we should add maybe as part of this PR or a final follow-up to
    this feature branch is disabling certain/all linting/formatting for the
    console. One way we might do this is by registering the console w/ a
    specific URI or URI scheme so we can check it when checking if we should
    lint. Or include it as a prop to the `MonacoProviders` component. This
    would require some changes to the current setup of setting/using the
    config on `MonacoProviders` static members/methods
    
    (This might not actually be breaking, it's more just notes for
    implementing in DHE)
    BREAKING CHANGE:
    The app should call `MonacoUtils.init` with a `getWorker` function that
    uses the JSON worker in addition to the general fallback worker when
    adding support for configuring ruff.
    mattrunyon authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3144edb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f606c0a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b89ed9 View commit details
    Browse the repository at this point in the history
  4. Fix TS error

    mattrunyon committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    25ba240 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    2778f27 View commit details
    Browse the repository at this point in the history