Clear viewers set to TextEditorPropertyAction on dispose

Fixes eclipse-platform/eclipse.platform.ui#1804
deepika-u · Apr 9, 2024 · e94dcfc · e94dcfc
1 parent bb54ca5
commit e94dcfc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...undles/org.eclipse.compare/compare/org/eclipse/compare/internal/ShowWhitespaceAction.java b/...undles/org.eclipse.compare/compare/org/eclipse/compare/internal/ShowWhitespaceAction.java
@@ -128,6 +128,9 @@ private void showWhitespace() {
 			for (int i = 0; i < viewers.length; i++) {
 				if (fNeedsPainters[i]) {
 					MergeSourceViewer viewer = viewers[i];
+					if (viewer == null) {
+						continue;
+					}
 					SourceViewer sourceViewer = viewer.getSourceViewer();
 					WhitespaceCharacterPainter painter;
 					if (fStore != null) {

diff --git a/...es/org.eclipse.compare/compare/org/eclipse/compare/internal/TextEditorPropertyAction.java b/...es/org.eclipse.compare/compare/org/eclipse/compare/internal/TextEditorPropertyAction.java
@@ -77,8 +77,14 @@ public void run() {
 	}
 
 	public void dispose() {
-		if (store != null)
+		if (viewers != null) {
+			for (int i = 0; i < viewers.length; i++) {
+				viewers[i] = null;
+			}
+		}
+		if (store != null) {
 			store.removePropertyChangeListener(this);
+		}
 	}
 
 	/**