[Fix] Fix the issue that single precision caculation is not runable on CUDA version #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
added
GPU & DCU & HPC
mohanchen
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this issue #5679
Important!!!!!!!!!!!!!!!!!:
This only fix the problem that single precision caculation is not runable on CUDA version. This is caused by a wrong macro definition in new fft, which caused the GPU single precision FFT not initializing at all.
But!!!!!!!!!!!!!!!!!!
According to this issue #5811
Current PW version does not support single precision at all. This is caused by some other incorrect codes. This pull request cannot fix this problem. If you try using GPU single precision caculation now, it will tell you that cusolver cannot invert matrix. This is the can problem as the #5811 problem. Before this pull request, ABACUS can not be launched correctly at all.