forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: support negative value in parse_expression #5826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exx when istep > 0
Refactor: modify exx loop for relax/md
merge from ESROAMER:no_force
mohanchen
approved these changes
Jan 7, 2025
mohanchen
added
Bugs
Bugs that only solvable with sufficient knowledge of DFT
Input&Output
Suitable for coders without knowing too many DFT details
Refactor
Refactor ABACUS codes
labels
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bugs
Bugs that only solvable with sufficient knowledge of DFT
Input&Output
Suitable for coders without knowing too many DFT details
Refactor
Refactor ABACUS codes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
parse_expression
function to process negative input, it will be parsed as a positive value. This PR is used to fix this problem.