-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use deepcopy when dumping mixed types #671
Conversation
CodSpeed Performance ReportMerging #671 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #671 +/- ##
==========================================
- Coverage 84.31% 84.30% -0.01%
==========================================
Files 81 81
Lines 7142 7144 +2
==========================================
+ Hits 6022 6023 +1
- Misses 1120 1121 +1 ☔ View full report in Codecov by Sentry. |
WalkthroughWalkthroughThe changes introduce a deep copy operation in the Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A UT is necessary
it is designed to reproduce the issue in the old code, and to show the bug is fixed in the revised code.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also consider copying the data in System
.
Use deepcopy when dumping mixed types in system level. Fix #670 .
Typically, users use the following command to dump list of systems to mixed_type:
This command will rebuild a new system with a new data dict, thus it does not change the original
system.data
.In #670 , when users use
on a system in standard format, it would directly convert the original
system.data
into mixed types, thus the originalsystem.data
would be changed.Use deepcopy to prevent this.
Summary by CodeRabbit
Bug Fixes
Tests