Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spin for lammps #738
add spin for lammps #738
Changes from 6 commits
b341ae7
a9416dc
ee66f22
589d8bf
40aefd4
67450ce
204a8ac
1287fcc
ad5808a
daa38ba
866f14b
b1439df
ee6f274
26f9875
94f0e50
596efaf
0a1bb76
1c758bd
78bab7e
4c2656c
ef386da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 239 in dpdata/lammps/dump.py
Codecov / codecov/patch
dpdata/lammps/dump.py#L239
Check warning on line 310 in dpdata/lammps/dump.py
Codecov / codecov/patch
dpdata/lammps/dump.py#L310
Check warning on line 314 in dpdata/lammps/dump.py
Codecov / codecov/patch
dpdata/lammps/dump.py#L313-L314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve warning message and add stacklevel
The warning message could be more informative, and
stacklevel
is missing.Apply this diff:
📝 Committable suggestion
🧰 Tools
🪛 Ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if it is over-designed to read the input file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we want to read spin information from the dump file, we need to search for keywords related to spin information based on the settings of the input file