Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add new behavioral test #8411

Closed
wants to merge 1 commit into from
Closed

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 26, 2024

Related Issues

Adds a new behavorial test based on this issue #8389

@silvanocerza this is also fixed by the subgraphs branch.

Note: This test will still fail currently with the subgraphs branch b/c Doc comparison is fragile when Documents have scores. By this I mean a Doc is assigned a float score by the Retriever and the Doc __eq__ method only does an exact comparison. This breaks when comparing floats due to the imprecision with long decimals.

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner September 26, 2024 11:15
@sjrl sjrl requested review from davidsbatista and silvanocerza and removed request for a team September 26, 2024 11:15
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11051101178

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.283%

Totals Coverage Status
Change from base Build 11035435372: 0.0%
Covered Lines: 7414
Relevant Lines: 8212

💛 - Coveralls

@silvanocerza
Copy link
Contributor

Integrated this in #8431 with 149f92f and some small fixes with c730077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants