Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Retry in tests/cmd/helper.go #240

Open
vdice opened this issue Jun 24, 2016 · 2 comments
Open

refactor Retry in tests/cmd/helper.go #240

vdice opened this issue Jun 24, 2016 · 2 comments
Labels
refactor

Comments

@vdice
Copy link
Member

vdice commented Jun 24, 2016

Refactor Retry to accept timeout of type time.Duration as opposed to type int, potentially enabling passing expected exit code was well. Alternatively, in #237 adds RetryUntilResult which does both, so Retry might be able to just invoke this function for most of its logic...
@vdice vdice added the refactor label Jun 24, 2016
@mboersma
Copy link
Member

I wonder if https://github.com/codeship/go-retro could simplify any of this code...

@Cryptophobia Cryptophobia mentioned this issue Mar 21, 2018
Open
@Cryptophobia
Copy link

This issue was moved to teamhephy/workflow-e2e#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mboersma @vdice @Cryptophobia