Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Retry in tests/cmd/helper.go #8

Open
Cryptophobia opened this issue Mar 21, 2018 · 1 comment
Open

refactor Retry in tests/cmd/helper.go #8

Cryptophobia opened this issue Mar 21, 2018 · 1 comment
Labels
refactor

Comments

@Cryptophobia
Copy link
Member

From @vdice on June 24, 2016 18:5

Refactor Retry to accept timeout of type time.Duration as opposed to type int, potentially enabling passing expected exit code was well. Alternatively, in deis/workflow-e2e#237 adds RetryUntilResult which does both, so Retry might be able to just invoke this function for most of its logic...

Copied from original issue: deis/workflow-e2e#240
@Cryptophobia
Copy link
Member Author

From @mboersma on June 28, 2016 22:31

I wonder if https://github.com/codeship/go-retro could simplify any of this code...

@Cryptophobia Cryptophobia mentioned this issue Mar 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cryptophobia