Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

WIP: declare "off_cluster_minio" #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kingdonb
Copy link

for an External minio server using s3.accesskey and s3.secretkey,
will add s3.regionendpoint later

WIP: to resolve #481

More changes will go in deis/builder deis/controller deis/database
deis/registry, all of which have dependencies on s3/swift storage

In PoC I overrode DEIS_MINIO_SERVICE_HOST and DEIS_MINIO_SERVICE_PORT

I'd like to use that shortcut and it seems safe, but I'm open to doing it another way if it's cleaner. I would decompose host and port from value in s3.regionendpoint, reorganizing values.yaml so the off-cluster minio configuration is very obvious.

I could not reliably use Deis Workflow on any of my (relatively not-top-of-the-line) portable machines via minikube or minishift without adding a remote storage server for minio, and adding some persistent disk. Can we get the configuration for this mode worked out in 2.19 final release?

for an External minio server using s3.accesskey and s3.secretkey,
will add s3.regionendpoint later

WIP: to resolve deis#481

More changes will go in deis/builder deis/controller deis/database
deis/registry, all of which have dependencies on s3/swift storage

(In PoC I overrode DEIS_MINIO_SERVICE_HOST and DEIS_MINIO_SERVICE_PORT,
I'd like to use that shortcut and it seems safe, but expose it in values
as s3.regionendpoint, reorganizing values.yaml so the off-cluster minio
configuration is very obvious.)
@kingdonb
Copy link
Author

kingdonb commented Aug 29, 2017

Values.global.storage "minio" <-- is this value read and used anywhere other than in charts/minio?

If not, we can just pick a different value instead of "minio" so that it will be distinct from internal minio.

https://gist.github.com/kingdonb/845945908336cbeefb3e8cce73ec5dc2

These changes were all I needed to enable off-cluster minio on my local/minikube Workflow instance.

(I deleted the charts/workflow/charts/minio chart because I don't know enough about gotl to get this done, I tried a few things before I arrived at "just try overwriting the variables" because the

{{- if (.Values.off_cluster_minio) }}

... did not work the way that I expected. I will gladly take pointers on gotl and improve this before merge. WIP.

@kingdonb
Copy link
Author

I thought I had better get some feedback before I went to the trouble and opened four separate pull requests on deis/builder, deis/registry, deis/database, and deis/controller... please take a look at my patch and suggest alternatives if you think it is not in good shape to merge. The better approach is probably not to try overwriting kubernetes service host and port variables... but I am new at this.

@kingdonb
Copy link
Author

This will be better if I follow the guidance in #481 more closely, namely the part about setting s3.regionendpoint

@mboersma
Copy link
Member

mboersma commented Sep 7, 2017

Jenkins, add to whitelist.

@kingdonb
Copy link
Author

Related to deis/monitor#191

If you want to support a cloud-neutral storage for swift objects, to be complete would also need to provide an answer for block storage or at least for the storage requirements of Grafana and InfluxDB

@kingdonb
Copy link
Author

Jenkins, test this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable endpoint for S3 object storage
3 participants