-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generics #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better typing and don't store additional attributes on the class
Except for things from strcs and collections
Support for looking at multiple annotations will be added another day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of nearly 10 months of me tackling this a bit at a time every few weeks.
All I wanted to do was this:
Turns out python type annotations aren't very nice to introspect and you have to do some fiddly things to understand when a type is optional or annotated or generic and how inheritance changes things.
I also wanted to make it so registering creators could be more powerful, which resulted in the need to be able to sort type annotations by complexity so that I could deterministically and efficiently find the most appropriate creator for a given type. With this sorting capability I'm able to look at the most specific creators before the most generic creators.
I also took a rabbit hole into resolving python typing ForwardRefs. This is where a type annotation is represented as a string at runtime because it was for a type not available at the time it was referenced. If these aren't resolved then strcs can't find the correct creator for that field. I will rejoice when I can make strcs support 3.13 and remove this resolving logic because of https://peps.python.org/pep-0649/
I've also slipped in package upgrades to use hatchling.