Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onReceivedError deprecation #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix onReceivedError deprecation #114

wants to merge 1 commit into from

Conversation

rignaneseleo
Copy link

Without this fix, the webview goes to error page on some devices without motives

Without this fix, the webview goes to error page on some devices without motives
@ocram ocram added the bug label Feb 20, 2017
@ocram
Copy link
Contributor

ocram commented Feb 20, 2017

Thanks a lot!

This is indeed an important issue that needs to get fixed.

However, from the documentation:

Note that unlike the deprecated version of the callback, the new version will be called for any resource (iframe, image, etc), not just for the main page.

So the new callback is not really a drop-in replacement for the old callback. I'm not really sure, yet, whether we should just add the call from one method to the other, or if there's something we could do in order to make the callbacks behave the same way. That would be great, of course.

Anyway, we should definitely leave this issue open and merge it soon, either in its current form or slightly modified. In the meantime, anybody who needs that fix immediately can insert it using their own WebViewClient in setWebViewClient.

@GitWessel
Copy link

@rignaneseleo this makes no sense to set a target api. Because the error handler is in webviewer also. Please update your webviewer this is not version bindend. Had same error before, you can subscribe on webviewer open beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants