Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setOnScrollChangeListener Added #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johncodeos
Copy link

@johncodeos johncodeos commented Dec 3, 2017

setOnScrollChangeListener by default it's only available for devices with 23 API and above. This pull add support for devices below 23 API. Also I added example on README.

@ocram
Copy link
Contributor

ocram commented Dec 4, 2017

Thank you!

How will this work with devices (and compile targets) both below and above API level 23? Will this be compatible? So <23, it would just add the missing method as a patch, and >=23 it would override the default implementation from View without any bad side effects?

@johncodeos
Copy link
Author

Exactly, I tested it and there is not any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants