Release 3.4.0

dell · Feb 2, 2023 · 32aecc2 · 32aecc2
1 parent a2d45ca
commit 32aecc2
Show file tree

Hide file tree

Showing 102 changed files with 10,854 additions and 9,017 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [3.4.0]() - 2023-02-01
+## [3.4.0]() - 2023-02-02
 ### Added
 - Get-OMEFabric
 - Get-OMEFabricUplink
@@ -15,9 +15,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Set-OMETemplateIdentityPool
 - Set-OMETemplateNetwork
 - Remove-OMEDevice
+- Remove-OMEDirectoryService
+- Remove-OMEUser
+- Improved Pester test coverage
+- Tested against OME 3.10 and OME-M 2.00.00
 
 ### Changed
-- New-OMEMcmGroup to create VIP
+- New-OMEMcmGroup to allow for VIP creation
 
 ## [3.3.3]() - 2023-01-23
 ### Fixed

diff --git a/DellOpenManage/DellOpenManage.psd1 b/DellOpenManage/DellOpenManage.psd1
@@ -1,132 +1,132 @@
-#
-# Module manifest for module 'DellOpenManage'
-#
-# Generated by: Trevor Squillario <Trevor.Squillario@Dell.com>
-#
-# Generated on: 1/23/2023
-#
-
-@{
-
-# Script module or binary module file associated with this manifest.
-RootModule = 'DellOpenManage.psm1'
-
-# Version number of this module.
-ModuleVersion = '3.3.3'
-
-# Supported PSEditions
-# CompatiblePSEditions = @()
-
-# ID used to uniquely identify this module
-GUID = '44c6339a-1c7e-4892-9d9c-9806818853c9'
-
-# Author of this module
-Author = 'Trevor Squillario <Trevor.Squillario@Dell.com>'
-
-# Company or vendor of this module
-CompanyName = 'Dell EMC'
-
-# Copyright statement for this module
-Copyright = '(c) 2021 Dell EMC. All rights reserved.'
-
-# Description of the functionality provided by this module
-Description = 'Dell OpenManage Enterprise PowerShell Module'
-
-# Minimum version of the PowerShell engine required by this module
-# PowerShellVersion = ''
-
-# Name of the PowerShell host required by this module
-# PowerShellHostName = ''
-
-# Minimum version of the PowerShell host required by this module
-# PowerShellHostVersion = ''
-
-# Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# DotNetFrameworkVersion = ''
-
-# Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# ClrVersion = ''
-
-# Processor architecture (None, X86, Amd64) required by this module
-# ProcessorArchitecture = ''
-
-# Modules that must be imported into the global environment prior to importing this module
-# RequiredModules = @()
-
-# Assemblies that must be loaded prior to importing this module
-# RequiredAssemblies = @()
-
-# Script files (.ps1) that are run in the caller's environment prior to importing this module.
-# ScriptsToProcess = @()
-
-# Type files (.ps1xml) to be loaded when importing this module
-# TypesToProcess = @()
-
-# Format files (.ps1xml) to be loaded when importing this module
-# FormatsToProcess = @()
-
-# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
-# NestedModules = @()
-
-# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
-FunctionsToExport = '*'
-
-# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
-CmdletsToExport = '*'
-
-# Variables to export from this module
-VariablesToExport = '*'
-
-# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
-AliasesToExport = '*'
-
-# DSC resources to export from this module
-# DscResourcesToExport = @()
-
-# List of all modules packaged with this module
-# ModuleList = @()
-
-# List of all files packaged with this module
-# FileList = @()
-
-# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
-PrivateData = @{
-
-    PSData = @{
-
-        # Tags applied to this module. These help with module discovery in online galleries.
-        # Tags = @()
-
-        # A URL to the license for this module.
-        # LicenseUri = ''
-
-        # A URL to the main website for this project.
-        ProjectUri = 'https://github.com/dell/OpenManage-PowerShell-Modules'
-
-        # A URL to an icon representing this module.
-        # IconUri = ''
-
-        # ReleaseNotes of this module
-        # ReleaseNotes = ''
-
-        # Prerelease string of this module
-        # Prerelease = ''
-
-        # Flag to indicate whether the module requires explicit user acceptance for install/update/save
-        # RequireLicenseAcceptance = $false
-
-        # External dependent modules of this module
-        # ExternalModuleDependencies = @()
-
-    } # End of PSData hashtable
-
- } # End of PrivateData hashtable
-
-# HelpInfo URI of this module
-# HelpInfoURI = ''
-
-# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
-# DefaultCommandPrefix = ''
-
-}
-
+#
+# Module manifest for module 'DellOpenManage'
+#
+# Generated by: Trevor Squillario <Trevor.Squillario@Dell.com>
+#
+# Generated on: 2/2/2023
+#
+
+@{
+
+# Script module or binary module file associated with this manifest.
+RootModule = 'DellOpenManage.psm1'
+
+# Version number of this module.
+ModuleVersion = '3.4.0'
+
+# Supported PSEditions
+# CompatiblePSEditions = @()
+
+# ID used to uniquely identify this module
+GUID = '44c6339a-1c7e-4892-9d9c-9806818853c9'
+
+# Author of this module
+Author = 'Trevor Squillario <Trevor.Squillario@Dell.com>'
+
+# Company or vendor of this module
+CompanyName = 'Dell EMC'
+
+# Copyright statement for this module
+Copyright = '(c) 2021 Dell EMC. All rights reserved.'
+
+# Description of the functionality provided by this module
+Description = 'Dell OpenManage Enterprise PowerShell Module'
+
+# Minimum version of the PowerShell engine required by this module
+# PowerShellVersion = ''
+
+# Name of the PowerShell host required by this module
+# PowerShellHostName = ''
+
+# Minimum version of the PowerShell host required by this module
+# PowerShellHostVersion = ''
+
+# Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+# DotNetFrameworkVersion = ''
+
+# Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
+# ClrVersion = ''
+
+# Processor architecture (None, X86, Amd64) required by this module
+# ProcessorArchitecture = ''
+
+# Modules that must be imported into the global environment prior to importing this module
+# RequiredModules = @()
+
+# Assemblies that must be loaded prior to importing this module
+# RequiredAssemblies = @()
+
+# Script files (.ps1) that are run in the caller's environment prior to importing this module.
+# ScriptsToProcess = @()
+
+# Type files (.ps1xml) to be loaded when importing this module
+# TypesToProcess = @()
+
+# Format files (.ps1xml) to be loaded when importing this module
+# FormatsToProcess = @()
+
+# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
+# NestedModules = @()
+
+# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
+FunctionsToExport = '*'
+
+# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
+CmdletsToExport = '*'
+
+# Variables to export from this module
+VariablesToExport = '*'
+
+# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
+AliasesToExport = '*'
+
+# DSC resources to export from this module
+# DscResourcesToExport = @()
+
+# List of all modules packaged with this module
+# ModuleList = @()
+
+# List of all files packaged with this module
+# FileList = @()
+
+# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
+PrivateData = @{
+
+    PSData = @{
+
+        # Tags applied to this module. These help with module discovery in online galleries.
+        # Tags = @()
+
+        # A URL to the license for this module.
+        # LicenseUri = ''
+
+        # A URL to the main website for this project.
+        ProjectUri = 'https://github.com/dell/OpenManage-PowerShell-Modules'
+
+        # A URL to an icon representing this module.
+        # IconUri = ''
+
+        # ReleaseNotes of this module
+        # ReleaseNotes = ''
+
+        # Prerelease string of this module
+        # Prerelease = ''
+
+        # Flag to indicate whether the module requires explicit user acceptance for install/update/save
+        # RequireLicenseAcceptance = $false
+
+        # External dependent modules of this module
+        # ExternalModuleDependencies = @()
+
+    } # End of PSData hashtable
+
+ } # End of PrivateData hashtable
+
+# HelpInfo URI of this module
+# HelpInfoURI = ''
+
+# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
+# DefaultCommandPrefix = ''
+
+}
+
diff --git a/DellOpenManage/Public/OME/Edit-OMEFabricUplink.ps1 b/DellOpenManage/Public/OME/Edit-OMEFabricUplink.ps1
@@ -57,7 +57,7 @@ function Get-FabricUplinkEditPayload($Name, $Description, $MediaType, $Ports, $N
     # Split $Ports into array by comma and trim whitespace
     $PortSplit = @()
     if ($Ports) {
-        $PortSplit = $($Ports.Split(",") | % { $_.Trim() })
+        $PortSplit = $($Ports.Split(",") | ForEach-Object { $_.Trim() })
     }
     $NetworkList = [System.Collections.ArrayList]@()
     if ($Mode -eq "Append") {

diff --git a/DellOpenManage/Public/OME/New-OMEFabric.ps1 b/DellOpenManage/Public/OME/New-OMEFabric.ps1
@@ -34,7 +34,7 @@ function Get-FabricPayload($Name, $Description, $DesignType, $SwitchAServiceTag,
     return $Payload
 }
 
-function Invoke-CheckOMEFabricApplicableNodes ($BaseUri, $Headers, $ContentType, $DesignType, $SwitchAServiceTag, $SwitchBServiceTag) {
+function Invoke-CheckOMEFabricApplicableNode ($BaseUri, $Headers, $ContentType, $DesignType, $SwitchAServiceTag, $SwitchBServiceTag) {
     $ApplicableNodesURL = $BaseUri + "/api/NetworkService/FabricDesigns('$($DesignType)')/NetworkService.GetApplicableNodes"
     Write-Verbose "Get fabric applicable nodes"
     Write-Verbose $ApplicableNodesURL
@@ -145,7 +145,7 @@ Try {
     $Headers."X-Auth-Token" = $SessionAuth.Token
     $ContentType = "application/json"
 
-    $CheckApplicableNodes = Invoke-CheckOMEFabricApplicableNodes -BaseUri $BaseUri -Headers $Headers -ContentType $ContentType -DesignType $DesignType -SwitchAServiceTag $SwitchAServiceTag -SwitchBServiceTag $SwitchBServiceTag
+    $CheckApplicableNodes = Invoke-CheckOMEFabricApplicableNode -BaseUri $BaseUri -Headers $Headers -ContentType $ContentType -DesignType $DesignType -SwitchAServiceTag $SwitchAServiceTag -SwitchBServiceTag $SwitchBServiceTag
     if (!$CheckApplicableNodes) {
         throw [System.Exception]::new("FabricException", "Fabric applicable nodes check failed. Check your chassis and IOM service tags.")
     }

diff --git a/DellOpenManage/Public/OME/New-OMEFabricUplink.ps1 b/DellOpenManage/Public/OME/New-OMEFabricUplink.ps1
@@ -39,7 +39,7 @@ function Get-FabricUplinkPayload($Name, $Description, $MediaType, $Ports, $Netwo
     $PortPayloads = @()
     $PortSplit = @()
     if ($null -ne $Ports) {
-        $PortSplit = $($Ports.Split(",") | % { $_.Trim() })
+        $PortSplit = $($Ports.Split(",") | ForEach-Object { $_.Trim() })
     }
     foreach ($Port in $PortSplit) {
         if ($Port -ne "") {